Remove GraphQL cache extension by rudransh-shrivastava · Pull Request #3702 · OWASP/Nest

rudransh-shrivastava · 2026-01-31T11:53:05Z

Proposed change

Resolves #3696

Remove cache extension and related code

Checklist

Required: I followed the contributing workflow
Required: I verified that my code works as intended and resolves the issue as described
Required: I ran make check-test locally: all warnings addressed, tests passed
I used AI for code, documentation, tests, or communication related to this PR

coderabbitai · 2026-01-31T11:53:26Z

Summary by CodeRabbit

Release Notes

Refactor
- Removed GraphQL query caching functionality and related cache invalidation mechanisms. Queries will no longer be cached, which may impact performance characteristics compared to previous versions.
Chores
- Removed associated cache configuration settings and deprecated cache management code.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Walkthrough

This PR removes the GraphQL cache extension implementation across the codebase, including the CacheExtension class, cache key generation and invalidation utilities, related settings, schema configuration, and comprehensive tests. Cache invalidation side effects are eliminated from mentorship mutation operations.

Changes

Cohort / File(s)	Summary
Cache Extension Removal `backend/apps/api/internal/extensions/__init__.py`, `backend/apps/api/internal/extensions/cache.py`	Removed module docstring and deleted entire CacheExtension implementation containing resolver caching, key generation, protected field detection, and cache invalidation primitives.
Settings Configuration `backend/settings/base.py`	Removed GRAPHQL_RESOLVER_CACHE_PREFIX and GRAPHQL_RESOLVER_CACHE_TIME_SECONDS configuration attributes.
Schema Configuration `backend/settings/graphql.py`	Removed CacheExtension import and its reference from Strawberry schema extensions list.
Mutation Cache Invalidation `backend/apps/mentorship/api/internal/mutations/module.py`, `backend/apps/mentorship/api/internal/mutations/program.py`	Removed on_commit callbacks that triggered cache invalidation during module and program creation/updates, and eliminated invalidate_program_cache import.
Test Removal `backend/tests/apps/api/internal/extensions/cache_test.py`	Deleted comprehensive test suite covering cache key generation, protected field detection, CacheExtension resolve behavior, and cache invalidation helpers.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Implement caching for GraphQL resolvers #2528 — Directly opposes this PR by introducing the GraphQL resolver caching implementation and cache-related symbols that are being removed.
fix: add GraphQL cache invalidation for programs and modules #3387 — Introduces the GraphQL cache extension and cache-invalidation calls in mentorship mutations that this PR removes.

Suggested reviewers

arkid15r

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Remove GraphQL cache extension' is directly related to the main change in the changeset, clearly summarizing the primary objective of removing the cache extension.
Description check	✅ Passed	The description references issue `#3696` and explicitly states the objective to remove the GraphQL cache extension and clean up related logic, which aligns with the changeset.
Linked Issues check	✅ Passed	The code changes fully satisfy issue `#3696`'s requirements by removing the cache extension, cache invalidation logic, related settings, and tests.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to removing the GraphQL cache extension and its dependencies as required by issue `#3696`; no extraneous modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

sonarqubecloud · 2026-01-31T11:54:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2026-01-31T11:59:01Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.70%. Comparing base (178aef0) to head (02e8f54).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3702      +/-   ##
==========================================
- Coverage   87.72%   87.70%   -0.03%     
==========================================
  Files         463      462       -1     
  Lines       14306    14277      -29     
  Branches     1903     1902       -1     
==========================================
- Hits        12550    12521      -29     
  Misses       1344     1344              
  Partials      412      412

Flag	Coverage Δ
backend	`87.45% <ø> (-0.04%)`	⬇️
frontend	`88.38% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 178aef0...02e8f54. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

remove GraphQL cache extension

02e8f54

github-actions bot added backend backend-tests labels Jan 31, 2026

coderabbitai bot approved these changes Jan 31, 2026

View reviewed changes

rudransh-shrivastava marked this pull request as ready for review January 31, 2026 17:17

rudransh-shrivastava requested review from arkid15r and kasya as code owners January 31, 2026 17:17

arkid15r approved these changes Feb 1, 2026

View reviewed changes

arkid15r added this pull request to the merge queue Feb 1, 2026

Merged via the queue into OWASP:main with commit ffeb5ee Feb 1, 2026
36 checks passed

coderabbitai bot mentioned this pull request Feb 8, 2026

Hide Unpublished Programs and Modules From Public View #3117

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Remove GraphQL cache extension#3702

Remove GraphQL cache extension#3702
arkid15r merged 1 commit intoOWASP:mainfrom
rudransh-shrivastava:refactor/remove-graphql-caching

rudransh-shrivastava commented Jan 31, 2026

Uh oh!

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Jan 31, 2026

Uh oh!

codecov bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Comments

Conversation

rudransh-shrivastava commented Jan 31, 2026

Proposed change

Checklist

Uh oh!

coderabbitai bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Release Notes

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

sonarqubecloud bot commented Jan 31, 2026

Quality Gate passed

Uh oh!

codecov bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai bot commented Jan 31, 2026 •

edited

Loading

codecov bot commented Jan 31, 2026 •

edited

Loading